Updates to the routines for occupancy - #470
Open
davidbowler wants to merge 9 commits into
Open
Conversation
Added flag to allow user to specify integer occupancies Track valence band maximum and conduction band minimum in occupy (except for Methfessel-Paxton) and write out gap when present, specifying direct or indirect and location
Test 007 identified a problem when there were degenerate levels which has now been fixed
Occupancies now correct for all spin cases, and made zero of energy for fixed spin common between two channels
davidbowler
added
area: main-source
This was referenced Aug 20, 2026
Mainly just making sure that the starting low electron number is sensible, and tweaking formatting
I had used very_small to decide whether an energy level was VBM or CBM (difference to one half) but this broke when tolElec was bigger than very_small. Only affected test007 but broke that comprehensively.
This is unlikely to be needed unless for debugging (test_007 made me think of it) but it's included for completeness. Small updates to documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement integer occupancies, place Fermi level mid-gap for semiconductors and insulators and write out gap when non-zero (none of these work with Methfessel-Paxton smearing!)