Documentation updates - #2958
Open
naddison36 wants to merge 7 commits into
Open
Conversation
naddison36
requested review from
clement-ux,
shahthepro and
sparrowDom
as code owners
August 3, 2026 09:39
sparrowDom
reviewed
Aug 7, 2026
| There are separate actions for: | ||
|
|
||
| - Contract formatting and linting | ||
| - Dapp formatting and linting |
|
|
||
| ## Coverage | ||
|
|
||
| The Hardhat plug-in [solidity-coverage](https://github.com/sc-forks/solidity-coverage#solidity-coverage) is used to gather Solidity code coverage. The configuration is in [.solcover.js](./.solcover.js). The coverage output is written to `coverage.json`. |
Member
There was a problem hiding this comment.
This part is also probably obsolete
|
|
||
| ### Echidna tests | ||
|
|
||
| [Echidna](https://github.com/crytic/echidna#echidna-a-fast-smart-contract-fuzzer-) is used for fuzzing tests. |
Member
There was a problem hiding this comment.
Echidna also doesn't work anymore. @clement-ux this is a known thing?
| @@ -486,31 +463,32 @@ All three identifiers **must match exactly** — if they drift, the script will | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity 0.8.23; | |||
Member
There was a problem hiding this comment.
this should probably be:
pragma solidity 0.8.28
Member
There was a problem hiding this comment.
Also All 3 000_Example.s.sol files pin solidity to:
pragma solidity ^0.8.0;
which should probably be updated to:
pragma solidity 0.8.28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary