Fix verify deposits - #2963
Merged
Merged
Conversation
naddison36
requested review from
clement-ux,
shahthepro and
sparrowDom
as code owners
August 4, 2026 23:35
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the validator/deposit verification tooling to work with the new CompoundingStakingStrategy (instead of the legacy SSV strategy), improves validator verification ergonomics with batch support, enriches staking snapshots with pubkeys + validator indexes, and makes the Talos client dependency lazy-loaded to avoid requiring private registry access for non-Talos Hardhat commands.
Changes:
- Switch verification flows (
verifyValidator,verifyDeposit(s),verifyBalances) to targetCompoundingStakingStrategyProxy. - Add batch validator verification via
--idswhile reusing a single beacon-state snapshot. - Improve staking snapshot output by backfilling pubkeys (via
ETHStakedlogs) and resolving validator indexes via the beacon API; lazily require@oplabs/talos-client.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| contracts/tasks/validatorCompound.js | Adds event-based pubkey backfill + beacon index lookup to improve deposit snapshot output. |
| contracts/tasks/tasks.js | Updates Hardhat task params to support --ids and make --index optional. |
| contracts/tasks/lib/signer.ts | Lazily loads the optional Talos client to avoid private registry requirements for normal commands. |
| contracts/tasks/beacon.js | Adds --ids batch verification and switches verification target to CompoundingStakingStrategy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+34
to
+38
| if (!talosClient) { | ||
| // Talos is an optional peer dependency so non-Talos Hardhat commands do not | ||
| // require credentials for the private package registry. | ||
| talosClient = require("@oplabs/talos-client") as TalosClient; | ||
| } |
Comment on lines
+966
to
+971
| const pubKeyHashes = deposits.map(({ pubKeyHash }) => pubKeyHash); | ||
| const blockBatchSize = 10000; | ||
|
|
||
| for (let startBlock = fromBlock; startBlock <= blockTag; ) { | ||
| const endBlock = Math.min(startBlock + blockBatchSize - 1, blockTag); | ||
| const logs = await strategy.provider.getLogs({ |
apexearth
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the validator tooling for the new
CompoundingStakingStrategy:CompoundingStakingStrategyinstead of the legacy SSV strategy for validator verification actions.--ids, reusing a single beacon-state snapshot across validators.ETHStakedevents and querying the beacon API.No contract or deployment changes are included.
Testing