Fallback to id field when name is missing in Minecraft velo plugin parsing#286
Conversation
There was a problem hiding this comment.
Hey thanks for the PR! Very nice, just some small things:
- please keep the comment you removed, it should still be applicable
- please add a check for null/empty json element and add a nice exception with a better error message than the default json one right now if it fails in either case. While we are at it.
|
I thought about leaving the comment in but decided strongly against it. Generally afaik only jar's which have a id, version and main class are considered valid (maybe more is needed). At this point in code we can assume that, because we already checked if there is a Velo Plugin spec. Lmk if you still demand the changes and which ones. |
Closes #285.