Skip to content

Fallback to id field when name is missing in Minecraft velo plugin parsing#286

Merged
Osiris-Team merged 1 commit into
Osiris-Team:masterfrom
Zoriot:fix-velo-plugins-without-name
Jun 26, 2026
Merged

Fallback to id field when name is missing in Minecraft velo plugin parsing#286
Osiris-Team merged 1 commit into
Osiris-Team:masterfrom
Zoriot:fix-velo-plugins-without-name

Conversation

@Zoriot

@Zoriot Zoriot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Closes #285.

@Osiris-Team Osiris-Team left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for the PR! Very nice, just some small things:

  • please keep the comment you removed, it should still be applicable
  • please add a check for null/empty json element and add a nice exception with a better error message than the default json one right now if it fails in either case. While we are at it.

@Zoriot

Zoriot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

I thought about leaving the comment in but decided strongly against it.
I don't think there is any reason why this comment should stay in. That should be self explainable that a Jar Name is not automatically the Name of the Plugin and should not be used as that. Such Comments more clutter the codebase then it helps imo

Generally afaik only jar's which have a id, version and main class are considered valid (maybe more is needed). At this point in code we can assume that, because we already checked if there is a Velo Plugin spec.
Why do you think additional validation and a better exception exception is needed?
I think that's a Point which likely will never fire off / or in weird broken Plugin edge cases where someone manually bricked it.

Lmk if you still demand the changes and which ones.

@Osiris-Team Osiris-Team left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k no problem

@Osiris-Team Osiris-Team merged commit 9160528 into Osiris-Team:master Jun 26, 2026
@Zoriot Zoriot deleted the fix-velo-plugins-without-name branch June 26, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SignedVelocity is not correctly regonized

2 participants