Repository navigation
fix(deps): upgrade @lhci/cli to 0.16 and pin minimatch 11 (#169) - #192
Merged
Merged
Conversation
@lhci/cli 0.16.0 bundles Lighthouse 13.6 and puppeteer-core 25, whose @puppeteer/browsers 3 no longer depends on extract-zip and whose chromium-bidi uses zod 4. That removes the two open Dependabot alerts (extract-zip, GHSA-jmr9-qjv8-65gv and GHSA-7pqw-9j4j-h8q3, which had no patched release) and the dev-only zod 3.23.8 finding instead of dismissing them. minimatch 9 and 10 under electron-builder and typescript-eslint are overridden to 11 for GHSA-g3hv-75wg-m249 (>= 7, < 11.0.1), the advisory the Dependabot Updates run has failed on since 2026-11-02. Every consumer in the tree calls `minimatch()` or `new Minimatch()`, which v11 keeps; `makeRe` and `AST`, the exports it drops, are unused. Lighthouse 13 removed the `uses-http2` audit, so it leaves `skipAudits`; `resource-summary`, which the budgets rely on, is still present (verified with a local collect + assert). The four "Set up Node 20" workflow step names already installed Node 22 and now say so; @lhci/cli 0.16 requires Node 22.19. pnpm audit: 6 findings -> 1 (basic-ftp 5.3.1 under lhci's proxy-agent, dev-only, already auto-dismissed on GitHub). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the remaining work on #169.
What changes
@lhci/cli0.14 → 0.16.0 (Lighthouse 12.1 → 13.6, puppeteer-core 22 → 25). The new@puppeteer/browsersno longer depends onextract-zip, andchromium-bidinow uses zod 4. That removes the two open Dependabot alerts (extract-zip, GHSA-jmr9-qjv8-65gv and GHSA-7pqw-9j4j-h8q3, no patched release exists) and the dev-only zod 3.23.8 finding, instead of dismissing them.minimatch@9andminimatch@10→ 11 viapnpm.overrides, for GHSA-g3hv-75wg-m249 (>= 7.0.0, < 11.0.1, medium), the advisory the Dependabot Updates run has failed on since 2026-11-02 (security_update_not_possible). The affected copies sit under electron-builder,@electron/universaland typescript-eslint. Every consumer callsminimatch()ornew Minimatch(), which v11 keeps; the exports v11 drops (makeRe,AST) are unused in the tree.lighthouserc.json: Lighthouse 13 removed theuses-http2audit, so it leavesskipAudits(Lighthouse ignores unknown ids, so this is cleanup).resource-summary, which every budget assertion relies on, is still present in 13.6. Docs intests/lighthouse/README.mdandCONTRIBUTING.mdupdated to match.@lhci/cli0.16 requires Node 22.19; every workflow usesnode-version: 22.Audit
pnpm audit: 6 findings → 1. The survivor is basic-ftp 5.3.1 under lhci'sproxy-agent(dev-only, only used when an HTTP proxy is configured, already auto-dismissed on GitHub as alert 130; the fix is a major bump thatget-urihas not taken).Verification
node --test tests/claude-code/*.test.mjs: 88 passpnpm test:pipeline: 133 passpnpm test:init: 1 failure incanva-generator.test.mjs, identical onmain(an awk syntax error inscripts/canva-fse/convert-html-to-blocks.shon this Linux awk; unrelated to dependencies)electron-vite buildandelectron-builder --dir --linux(exercisesapp-builder-lib's file matcher on minimatch 11) all pass; the smoke test passes locally (GUI launched and reached the setup view)lhci collect+lhci assertwith this repo'slighthouserc.jsonagainst a local static page runs theresource-summarybudgets and skipsis-on-httpsas before (the only failure was the probe page's own a11y score). Thelighthouse-ciworkflow runs on this PR becausepackage.jsonandpnpm-lock.yamlchanged, so the real WooCommerce gate is exercised here; see the known/cart/performance flakiness intests/lighthouse/README.mdif it fails on a slow runner.After merge
The next Dependabot Updates run should be green: no open alert has a published fix left to apply. GitHub will mark alerts 106 and 113 fixed once
maincarries this lockfile.🤖 Generated with Claude Code