Repository navigation
fix(gui): portable Canva converter, clearer prerequisites banner, executable script (#191) - #199
Merged
Merged
Conversation
Open
7 tasks
…cutable script (#191) Three items from the demo-readiness checklist. - scripts/canva-fse/convert-html-to-blocks.sh used gawk's three-argument match() with a capture array in its heading, paragraph, image and button rules. mawk (Debian and Ubuntu's awk) and BWK awk (macOS) reject it with "syntax error at or near ,", so the Canva path of the setup wizard, which the GUI's Convert design screen delegates to, failed on this Ubuntu host before WordPress was even involved. The rules now use POSIX match() with RSTART/RLENGTH and two small helpers (attr, inner_text); the bats suite for the script passes 9/9 on mawk (2 failed before) and the init-wizard suite passes 71/71. - The Prerequisites banner opened with "Ready to use this template: NO", the first thing a new user read when a check failed. readinessSummary() now says what is wrong and which checks to fix ("Not ready yet: 2 checks need attention" plus the failing check names, or an all-clear naming the product); optional software never counts, and a run that did not complete points at the raw output. Unit-tested. - wordpress-local.sh is tracked as 100755: the docs call it as ./wordpress-local.sh. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
PAMulligan
changed the title
PAMulligan
force-pushed
the
fix/demo-readiness-191
branch
from
November 8, 2026 20:23
b9ba84d to
c29059c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three items from the #191 checklist (does not close it; the timed end-to-end run, the visual baselines and the recording remain). Part of #186.
Canva converter runs on any awk
scripts/canva-fse/convert-html-to-blocks.shused gawk's three-argumentmatch()with a capture array in the heading, paragraph, image and button rules. mawk (Debian/Ubuntu) and BWK awk (macOS) reject it withsyntax error at or near ,. On this Ubuntu 26.04 host that made the setup wizard's Canva path fail, which is the path the GUI's Convert design screen delegates to, so the demo run would have broken before WordPress was involved. The rules now use POSIXmatch()withRSTART/RLENGTHand two helpers (attr,inner_text), keeping the old semantics (first attribute occurrence, text up to the last closing tag).Before:
tests/canva-fse/convert-html-to-blocks.bats7/9 on mawk,tests/init/unit/canva-generator.test.mtsfailing. After: 9/9 and the whole init-wizard suite 71/71. CI's Canva e2e runs the same script on the PR.Prerequisites banner says what to fix
The banner opened with "Ready to use this template: NO". New copy, from a pure, unit-tested
readinessSummary():The script's own output is unchanged; only the panel's copy moved.
wordpress-local.sh is executable in git
Tracked as 100755 now; the docs call it as
./wordpress-local.sh.Verification
GUI lint, typecheck, 103 unit tests (5 new), build and smoke pass;
pnpm test:init71/71; the Canva bats suite 9/9 on mawk 1.3.4.🤖 Generated with Claude Code