Repository navigation
ci(gui): attach installers to a draft release and publish it (#189 follow-up) - #200
Merged
Merged
Conversation
The first dispatch of the new chain built and packaged on all three platforms but every upload failed with "HTTP 422: Cannot upload assets to an immutable release": this repository has GitHub's immutable releases enabled, unlike Aurelius, so nothing can be attached once a release is published, and no already-published release can be back-filled. The chain is now draft first. release-please creates the tag and a draft release (`draft` plus `force-tag-creation`, so the tag exists immediately and release-please can still find the previous release next time); the called workflow builds, attaches the installers to the draft and publishes it in a final job that only runs when every platform succeeded. A manual dispatch with a tag is refused up front unless that release is still a draft, and the `on: release` trigger is gone (it could only ever fail here). Docs updated accordingly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
Author
|
Both test dispatches from this branch (commit e5c1b5a) behaved as designed:
What remains unproven until a real release: release-please creating the draft with the eager tag, and the publish job flipping it. The next Release PR merge after this lands is the one to watch; if a platform fails there, the draft stays and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #198, which merged while the first dispatch result was still coming in. Reopens the work on #189. Part of #186.
What #198's chain cannot do here
The dispatch of the merged chain against v2.1.4 (run 42518497713) built and packaged on all three platforms in about 90 seconds each, then every upload failed with
HTTP 422: Cannot upload assets to an immutable release. This repository has GitHub's immutable releases enabled (the release objects carryimmutable: true; Aurelius's do not). Nothing can be attached after publication, so the merged publish-then-attach chain will fail at its last step on every release, and no already-published release (v2.1.4, v2.2.0) can be back-filled.Fix: draft first
release-please-config.json:"draft": trueand"force-tag-creation": true. release-please creates the tag immediately and the Release as a draft (without the eager tag GitHub creates it only on publish, which release-please's docs say breaks its lookup of the previous release).release-please.ymlstill callsgui-release.ymlin the same run with the tag.gui-release.ymlnow has three jobs:checkrefuses a tag whose release is not a draft, with a clear message;build(unchanged otherwise) attaches the installers to the draft;publishruns only when every platform succeeded and flips the draft to published, listing the assets in the job summary.workflow_dispatchwith a tag reruns attach-and-publish for a draft an earlier run left unpublished; without a tag it is a dry run that keeps the installers as artifacts. Therelease: publishedtrigger is removed, since on this repository it could only ever fail.docs/GUI.mdanddocs/RELEASING.mddescribe the chain and the recovery path.Verification
gh workflow run gui-release.yml -f tag=v2.1.4(a published release): the check job fails with the "already published" message and the build is skipped.Flavian-<version>.AppImage,Flavian Setup <version>.exeand the two DMGs.🤖 Generated with Claude Code