Repository navigation
feat: show the task/document title in notification emails - #4
Merged
Merged
Conversation
The assignment and mention emails previously said only "A task was assigned to you" / "You were mentioned", with no indication of which task or document — the recipient had to click through to find out. Core now publishes an entity_title field on the notification events (see Paca-AI/paca). Read it and weave it into both the subject and body, e.g. "Task assigned: Ship the landing page" and "Ada assigned you the task \"Ship the landing page\".". When entity_title is empty (an older core, or a title that couldn't be resolved) the original title-less copy is used verbatim, so this degrades gracefully against any core version. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
pikann
approved these changes
Oct 7, 2026
pikann
left a comment
pikann
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for the contribution! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The assignment and mention emails say only "A task was assigned to you" / "You were mentioned", with no indication of which task or document — the recipient has to click through to find out. The in-app notification already shows the task title; this brings the email up to parity.
What
Core now publishes an
entity_titlefield on the notification events (Paca-AI/paca#553). This PR reads it and weaves it into both the subject and body:Task assigned: Ship the landing pageAda assigned you the task "Ship the landing page".You were mentioned in "Ship the landing page"Ada mentioned you in a comment on "Ship the landing page".You were mentioned in "Q4 roadmap"Ada mentioned you in the document "Q4 roadmap".You were mentioned in "Ship the landing page"Ada mentioned you in the description of "Ship the landing page".Graceful degradation: when
entity_titleis empty (an older core that predates the field, or a title that couldn't be resolved) the original title-less copy is used verbatim — so this is safe to ship against any core version.The title flows through the existing escaping/encoding (
escapeHTMLin the body, Q-encoding in the subject), so no new injection surface.Testing
go vet .andgo test .pass (including newTestRenderNotificationEmail_IncludesEntityTitleand..._FallsBackWithoutTitle).tinygo build -target=wasip1 -buildmode=c-sharedsucceeds (uses onlystrings/fmt, no new reflect/template usage).🤖 Generated with Claude Code