Skip to content

fix(web): save Timeline/board filters per user by default (PE-1) - #545

Merged
pikann merged 1 commit into
Paca-AI:masterfrom
prakruthi2411:feature/PE-1-per-user-timeline-filters
Oct 5, 2026
Merged

pikann merged 1 commit into
Paca-AI:masterfrom
prakruthi2411:feature/PE-1-per-user-timeline-filters

Conversation

@prakruthi2411

Copy link
Copy Markdown
Contributor

Summary

Implements PE-1 — PACA Timeline Board Filters Should Be Saved Per User.

  • View settings already persist in a per-user override (PUT …/views/:id/config)
  • The primary save action for people with views.write is now Save only for me, so filters no longer publish to the whole team by accident
  • Save for everyone remains in the dropdown for the team default
  • E2E specs/feature files updated to match the new footer

Test plan

  • Open Timeline (or Product Backlog) view settings as an Admin/Editor
  • Change a filter or Sort by → primary button is Save only for me
  • Save, then reopen the board as the same user → filters are restored
  • Open the same board as another user → they still see the team default
  • Dropdown still offers Save for everyone, and that updates the shared view
  • A Viewer still sees a single Save button (personal only)

Made with Cursor

Timeline and board filter changes now save only for the current user unless
they explicitly choose Save for everyone from the dropdown.

Co-authored-by: Cursor <cursoragent@cursor.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Minor suggestions only — one doc/spec consistency nit.

Reviewed changes

  • Footer action swap (view-settings-panel.tsx): for views.write holders the split button's primary action is now handleSave ("Save only for me", gated on differsFromEffective), and the dropdown now offers handleSaveForEveryone ("Save for everyone", gated on differsFromShared). Viewers still get the single plain "Save". This is an exact swap of the two existing actions — handlers, gates, and the persistence paths are otherwise untouched.
  • e2e specs: view-settings.spec.ts reorders the locator helpers (saveOnlyForMeButton is primary; saveDropdownTrigger is now its following sibling) and saveForEveryoneAndWaitClosed opens the dropdown first; interaction-views.spec.ts admin save tests now drive "Save only for me".
  • Gherkin features: view-settings.feature and view-settings-fields.feature prose updated to describe personal-first saving.

ℹ️ Nitpicks

  • view-settings-fields.feature now says the field scenarios' "the user saves the view settings" means "Save only for me", but the field-picker tests that actually save still use saveForEveryoneAndWaitClosed and assert the shared config (view-settings.spec.ts:716, :737, :756 — e.g. expect(view.shared_config.fields).toContain("due_date")). Align the prose with the tests, or move those tests onto the new primary save, so the feature file and its spec agree.

Pullfrog  | Fix it ➔ | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@pikann pikann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution! 🚀

@pikann
pikann merged commit adfc742 into Paca-AI:master Oct 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants