Repository navigation
fix(web): save Timeline/board filters per user by default (PE-1) - #545
Merged
pikann merged 1 commit intoOct 5, 2026
Merged
Conversation
Timeline and board filter changes now save only for the current user unless they explicitly choose Save for everyone from the dropdown. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
ℹ️ Minor suggestions only — one doc/spec consistency nit.
Reviewed changes
- Footer action swap (
view-settings-panel.tsx): forviews.writeholders the split button's primary action is nowhandleSave("Save only for me", gated ondiffersFromEffective), and the dropdown now offershandleSaveForEveryone("Save for everyone", gated ondiffersFromShared). Viewers still get the single plain "Save". This is an exact swap of the two existing actions — handlers, gates, and the persistence paths are otherwise untouched. - e2e specs:
view-settings.spec.tsreorders the locator helpers (saveOnlyForMeButtonis primary;saveDropdownTriggeris now its following sibling) andsaveForEveryoneAndWaitClosedopens the dropdown first;interaction-views.spec.tsadmin save tests now drive "Save only for me". - Gherkin features:
view-settings.featureandview-settings-fields.featureprose updated to describe personal-first saving.
ℹ️ Nitpicks
view-settings-fields.featurenow says the field scenarios' "the user saves the view settings" means "Save only for me", but the field-picker tests that actually save still usesaveForEveryoneAndWaitClosedand assert the shared config (view-settings.spec.ts:716,:737,:756— e.g.expect(view.shared_config.fields).toContain("due_date")). Align the prose with the tests, or move those tests onto the new primary save, so the feature file and its spec agree.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
pikann
approved these changes
Oct 5, 2026
pikann
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for the contribution! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Implements PE-1 — PACA Timeline Board Filters Should Be Saved Per User.
PUT …/views/:id/config)views.writeis now Save only for me, so filters no longer publish to the whole team by accidentTest plan
Made with Cursor