PPR-26: Book import workflow rework - #22
Open
Eoic wants to merge 19 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a design/spec document describing a reworked book import workflow, separating digital/physical import into distinct bottom sheets and introducing a multi-file digital import flow with a results/commit step.
Changes:
- Documented new bottom-sheet structure (
AddBookSheetScaffold) to standardize fixed header/body/footer layout across add-book flows. - Specified a multi-file digital import selection sheet (
DigitalBookImportSheet) and a processing/commit results sheet (BookImportResultsSheet) with retry/removal and cleanup rules. - Outlined verification coverage expectations (widget/model tests) and operational assumptions for the workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - Removing a ready row deletes the temporary imported book file created by `BookImportService`. | ||
| - Retrying metadata processing starts from the original bytes; retrying a commit reuses its existing parsed result and temporary file. | ||
| - Cancelling, closing, or dismissing the results sheet deletes every successful-but-uncommitted temporary file. |
…streamline processing
…usReader/client into feature/PPR-26-book-imports-rework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Summary
Testing
UI evidence
Compatibility and migration
Notes
Checklist