Skip to content

Issue 119 cli for model loading - #140

Open
cooperlab wants to merge 3 commits into
devfrom
issue-119-CLI_for_model_loading
Open

Issue 119 cli for model loading#140
cooperlab wants to merge 3 commits into
devfrom
issue-119-CLI_for_model_loading

Conversation

@cooperlab

Copy link
Copy Markdown
Contributor

Create a CLI for loading and unloading models.

@cooperlab
cooperlab requested review from RaminNateghi and andsild and removed request for andsild August 22, 2024 19:28
@cooperlab

cooperlab commented Aug 22, 2024

Copy link
Copy Markdown
Contributor Author

@andsild @RaminNateghi @marinayad @abs711 Please provide feedback on the model loading CLI interface described in the README.

@andsild

andsild commented Aug 22, 2024

Copy link
Copy Markdown
Collaborator

Nice, quite thorough with examples

@RaminNateghi

Copy link
Copy Markdown
Collaborator

That's a great interface that will meet all our needs.
The only thing I'd suggest is making the URL to the Triton server an input argument for the model CLI. The current interface doesn't take in the URL if I'm not mistaken.
By the way, I couldn't find the load_model.py file in the repository directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants