fix: exclude generated TypeScript sources from package - #473
fix: exclude generated TypeScript sources from package#473Kobe-Kwanten wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe package version is now 1.7.4. The build excludes generated TypeScript sources from ChangesPackage verification
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR tightens npm package contents and adds release-time validation without introducing a concrete runtime, security, or deployment risk. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
Fixes NodeNext + verbatimModuleSyntax consumer errors by preventing generated .ts sources from being published alongside the compiled CommonJS output.
If there's any reason why the .ts files were included on purpose, I'm happy to close this PR and rely on local patches instead.
Summary
distonly contains TypeScript compiler output1.7.4and run the packaging check in the publish workflowSummary by CodeRabbit