Skip to content

test(validation): add entity tuple validation regression assertions - #3100

Open
gcoinstash-cmd wants to merge 3 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788061701
Open

test(validation): add entity tuple validation regression assertions#3100
gcoinstash-cmd wants to merge 3 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788061701

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Aug 30, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance Improvements
    • Improved relationship and attribute data processing by grouping records into batches, reducing the number of database operations.
    • Added efficient handling for empty data collections.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e2f399ae-818e-4623-a371-8424e0e902b3

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and ff18b70.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The Postgres data writer now inserts relationships and attributes in 500-row batches. It uses squirrel multi-row INSERT statements and skips empty collections.

Changes

Postgres batch inserts

Layer / File(s) Summary
Chunked relationship and attribute inserts
internal/storage/postgres/data_writer.go
batchInsertRelationships and batchInsertAttributes build and queue one squirrel multi-row INSERT per 500-row chunk. Both methods return early for empty input. Relationship inserts preserve the conflict constraint, and attribute values use protojson marshaling.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ff18b

The batching change preserves correct result consumption and introduces no identified merge-blocking product or production risk; it is merge-ready after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes validation regression assertions, but the changeset updates PostgreSQL relationship and attribute inserts to use batches of 500 rows. Rename the title to describe the implemented storage change, for example: "storage(postgres): batch relationship and attribute inserts".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant