Skip to content

test(validation): add entity tuple validation regression assertions - #3101

Open
gcoinstash-cmd wants to merge 4 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788062356
Open

test(validation): add entity tuple validation regression assertions#3101
gcoinstash-cmd wants to merge 4 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788062356

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Aug 30, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance Improvements
    • Improved bulk relationship and attribute storage by grouping records into batches.
    • Reduced the number of database operations required when saving large collections.
    • Skipped unnecessary database work when there are no relationships or attributes to store.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e21ea449-b6e1-47b4-b703-c880b3590f92

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and f241fea.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The PostgreSQL data writer now groups relationship tuples and attributes into chunks of 500. It queues one multi-row INSERT query per chunk and skips empty collections. Existing conflict handling and attribute value marshaling remain unchanged.

Changes

PostgreSQL batch inserts

Layer / File(s) Summary
Chunked relationship and attribute inserts
internal/storage/postgres/data_writer.go
batchInsertRelationships and batchInsertAttributes use multi-row squirrel INSERT statements for chunks of 500 records. Both methods return early for empty collections. Relationship conflict handling and attribute protojson marshaling remain unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f241f

The change is localized, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes validation regression tests, but the changeset updates PostgreSQL relationship and attribute batch inserts with chunked multi-row queries. Rename the pull request to describe the storage changes, such as "Optimize PostgreSQL relationship and attribute batch inserts".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant