Skip to content

test(validation): add entity tuple validation regression assertions - #3102

Open
gcoinstash-cmd wants to merge 5 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788088378
Open

test(validation): add entity tuple validation regression assertions#3102
gcoinstash-cmd wants to merge 5 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788088378

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Aug 30, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance
    • Improved bulk data processing by inserting relationship and attribute records in batches.
    • Reduced unnecessary database work when there are no records to insert.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e3f49264-78a6-463c-af80-c24ed37dde24

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and d74b5b2.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The PostgreSQL writer now uses squirrel to build batched INSERT statements for relationships and attributes. Each method processes up to 500 rows per statement and returns immediately when its input is empty.

Changes

PostgreSQL batch inserts

Layer / File(s) Summary
Chunked relationship and attribute inserts
internal/storage/postgres/data_writer.go
batchInsertRelationships and batchInsertAttributes build squirrel INSERT statements in batches of 500. Relationship inserts preserve the conflict- ignore suffix. Empty inputs return without queueing statements.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to d74b5

The change is localized to PostgreSQL batch writes, adding chunked inserts and empty-input handling; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes validation regression assertions, but the changeset summary describes PostgreSQL batch insert refactoring with Squirrel and 500-row batching. Update the title to describe the PostgreSQL batch insert refactoring, query builder usage, and row batching.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant