Skip to content

test(validation): add entity tuple validation regression assertions - #3103

Open
gcoinstash-cmd wants to merge 6 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788090834
Open

test(validation): add entity tuple validation regression assertions#3103
gcoinstash-cmd wants to merge 6 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788090834

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Aug 30, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance Improvements
    • Improved bulk relationship and attribute storage operations by grouping records into batches.
    • Reduced the number of database operations required when saving large collections.
    • Preserved duplicate handling for relationships and JSON formatting for attribute values.
    • Empty collections are now skipped without issuing unnecessary database operations.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 720e7844-dc5f-4f63-a2ca-7ad3b0e0fb4b

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and b7832b9.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

Postgres relationship and attribute batch inserts now fetch complete collections, skip empty inputs, and queue multi-row INSERT statements in chunks of up to 500 rows. Existing conflict handling, normalization, and JSON marshaling remain unchanged.

Changes

Postgres batch insert chunking

Layer / File(s) Summary
Chunked relationship and attribute inserts
internal/storage/postgres/data_writer.go
batchInsertRelationships and batchInsertAttributes use squirrel to build one multi-row INSERT per chunk of up to 500 rows. Empty collections return without queueing queries. Existing conflict handling, subject-relation normalization, and protojson marshaling remain in place.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b7832

This change adds validation regression assertions, and no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes validation regression assertions, but the changeset rewrites PostgreSQL relationship and attribute batch inserts to use chunked multi-row INSERT queries. Update the title to describe the batch insert rewrite, for example: "optimize PostgreSQL batch inserts with chunked multi-row queries". If validation tests are intended, include those changes in the pull request.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant