Skip to content

test(validation): add entity tuple validation regression assertions - #3105

Open
gcoinstash-cmd wants to merge 8 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788133725
Open

test(validation): add entity tuple validation regression assertions#3105
gcoinstash-cmd wants to merge 8 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788133725

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Aug 30, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance Improvements
    • Improved bulk data writing by grouping relationship and attribute records into batches.
    • Reduced the number of database operations needed when saving large datasets.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c1c22161-f52b-41d3-af96-54671f83299f

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and 44bcd7d.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The PostgreSQL data writer now inserts relationships and attributes in chunks of up to 500 entries. Each chunk uses one squirrel-built INSERT statement.

Changes

PostgreSQL batch inserts

Layer / File(s) Summary
Chunked relationship and attribute inserts
internal/storage/postgres/data_writer.go
batchInsertRelationships and batchInsertAttributes split inputs into 500-entry chunks. Each chunk builds one squirrel INSERT statement. Relationship inserts preserve the conflict suffix, and attribute values remain protojson-marshaled.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 44bcd

The PR is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes validation regression assertions, but the changeset updates PostgreSQL relationship and attribute batch inserts with 500-entry chunking. The title does not describe the primary imp… Rename the pull request to describe the PostgreSQL batch insert chunking change, for example: "Optimize PostgreSQL relationship and attribute batch inserts".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title describes validation regression assertions, but the changeset updates PostgreSQL relationship and attribute batch inserts with 500-entry chunking. The title does not describe the primary implementation change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant