Skip to content

test(validation): add entity tuple validation regression assertions - #3107

Open
gcoinstash-cmd wants to merge 9 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788154288
Open

test(validation): add entity tuple validation regression assertions#3107
gcoinstash-cmd wants to merge 9 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788154288

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Aug 31, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance
    • Improved bulk data processing by grouping relationship and attribute records into batches.
    • Reduced the number of database operations required when storing large collections of records.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c517c308-ccf9-4d22-bbb8-a46390af1aa9

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and 63a03c1.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The PostgreSQL data writer now replaces per-record inserts with chunked, multi-row squirrel inserts for relationships and attributes. Empty collections return without queuing inserts. Relationship conflict handling and attribute value marshaling remain unchanged.

Changes

PostgreSQL batch insert optimization

Layer / File(s) Summary
Chunked relationship and attribute writers
internal/storage/postgres/data_writer.go
batchInsertRelationships and batchInsertAttributes now build multi-row inserts in chunks of 500. Both methods return early for empty collections. Relationship inserts preserve subject-relation normalization and conflict handling. Attribute inserts preserve protojson value marshaling.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 63a03

The change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the stated validation regression assertions, but it does not mention the unrelated PostgreSQL batch-insert changes that also appear in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant