Skip to content

test(validation): add entity tuple validation regression assertions - #3108

Open
gcoinstash-cmd wants to merge 10 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788207328
Open

test(validation): add entity tuple validation regression assertions#3108
gcoinstash-cmd wants to merge 10 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788207328

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Aug 31, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance Improvements
    • Improved bulk data processing by grouping relationship and attribute records into batches.
    • Reduced the number of database operations required when saving large sets of records.
    • Preserved duplicate-handling behavior for relationship data.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 9b71b7e6-d37a-43bc-aa5f-8286e6e3f980

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and 21f77de.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Postgres relationship and attribute batch writes now build multi-row INSERT statements in chunks of 500. Empty inputs return without queueing. Relationship inserts retain conflict handling, and attribute serialization errors remain unchanged.

Changes

Postgres batch insert chunking

Layer / File(s) Summary
Chunked relationship and attribute insert builders
internal/storage/postgres/data_writer.go
batchInsertRelationships and batchInsertAttributes now build squirrel multi-row INSERT statements in chunks of 500. Each chunk creates one batch entry. Empty inputs return early. Relationship conflict handling and attribute protojson.Marshal errors remain preserved.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 21f77

The PR adds validation regression assertions, and no actionable merge-blocking risk remains at the current head.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes validation regression tests, but the changeset rewrites PostgreSQL relationship and attribute inserts to use chunked multi-row batches. Rename the pull request to describe the PostgreSQL batch insert changes, for example: "storage(postgres): batch relationship and attribute inserts".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant