test(validation): add entity tuple validation regression assertions - #3109
test(validation): add entity tuple validation regression assertions#3109gcoinstash-cmd wants to merge 11 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughPostgreSQL relationship and attribute inserts now group up to 500 records per SQL statement. The changes preserve conflict handling, ellipsis normalization, protobuf JSON serialization, and error propagation. ChangesPostgreSQL insert batching
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR updates PostgreSQL batch insertion to skip empty collections and group writes while preserving existing conflict and serialization handling; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Title checkResolution Rename the pull request to describe the PostgreSQL insert batching change, such as "perf(storage): batch PostgreSQL relationship and attribute inserts". If validation tests are the intended change, provide the corresponding test changes or correct the pull request context. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
Summary of Changes
internal/validation.go test -v ./internal/validation: 11/11 specs passed 100% green.Summary by CodeRabbit