Skip to content

test(validation): add entity tuple validation regression assertions - #3110

Open
gcoinstash-cmd wants to merge 12 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788208043
Open

test(validation): add entity tuple validation regression assertions#3110
gcoinstash-cmd wants to merge 12 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788208043

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Aug 31, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance Improvements
    • Improved bulk data write performance by processing relationship and attribute records in batches.
    • Reduced database overhead when inserting large collections of records.
    • Empty collections are handled without unnecessary processing.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 4a59c91f-3c4a-4fe0-9de2-84c01642e588

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and 98e72a3.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Postgres batch insert updates

Layer / File(s) Summary
Chunked relationship and attribute inserts
internal/storage/postgres/data_writer.go
Relationship and attribute records are grouped into 500-row multi-value INSERT statements. Relationship normalization and conflict suppression remain unchanged. Attribute JSON marshaling errors still stop processing. Empty collections return without queuing statements.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 98e72

The PostgreSQL write path changes batching behavior, but no actionable merge-blocking risk remains; the PR is ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes validation regression assertions, but the listed changes modify PostgreSQL data writing to batch relationship and attribute inserts. The title does not summarize the primary change… Rename the pull request to describe the PostgreSQL insert batching change, or update the change summary to include the validation test files and assertions described by the title.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title describes validation regression assertions, but the listed changes modify PostgreSQL data writing to batch relationship and attribute inserts. The title does not summarize the primary change in the changeset.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant