Skip to content

test(validation): add entity tuple validation regression assertions - #3122

Open
gcoinstash-cmd wants to merge 16 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788308233
Open

test(validation): add entity tuple validation regression assertions#3122
gcoinstash-cmd wants to merge 16 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788308233

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Sep 2, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance Improvements
    • Improved bulk relationship and attribute data writes by processing records in batches.
    • Reduced unnecessary work when there are no records to write.
    • Preserved existing conflict handling, value formatting, and error reporting behavior.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: ba4803a3-86a7-4284-b593-81ded8fae167

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and b5641b2.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Changes

PostgreSQL batch inserts

Layer / File(s) Summary
Chunked insert generation
internal/storage/postgres/data_writer.go
Relationship and attribute inserts now build multi-row SQL statements in chunks of 500 records. Empty collections return immediately. Existing normalization, conflict handling, marshaling, and error propagation remain in place.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b5641

The change is localized, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes validation regression assertions, but the changeset summary describes PostgreSQL relationship and attribute insert batching in chunks of 500 records. The title does not identify th… Rename the title to describe the PostgreSQL insert batching change, for example: "Batch PostgreSQL relationship and attribute inserts in chunks".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title describes validation regression assertions, but the changeset summary describes PostgreSQL relationship and attribute insert batching in chunks of 500 records. The title does not identify the primary change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant