Skip to content

test(validation): add entity tuple validation regression assertions - #3123

Open
gcoinstash-cmd wants to merge 17 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788316834
Open

test(validation): add entity tuple validation regression assertions#3123
gcoinstash-cmd wants to merge 17 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788316834

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Sep 2, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance
    • Improved storage write efficiency by grouping relationship and attribute records into batches of up to 500.
    • Empty record collections now return without performing unnecessary work.
  • Bug Fixes
    • Preserved relationship normalization and conflict handling while maintaining existing attribute value processing and error reporting.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 907b9e45-2cd8-41d0-bb76-ac2d55a47b76

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and b194b01.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Postgres relationship and attribute inserts now use Squirrel builders to queue batches of up to 500 records. Empty inputs return immediately. Existing normalization, conflict handling, JSON marshaling, and error propagation remain unchanged.

Changes

Postgres batch inserts

Layer / File(s) Summary
Batch insert query generation
internal/storage/postgres/data_writer.go
Relationship and attribute records are grouped into batches of up to 500. Each batch generates one Squirrel insert query. Existing normalization, conflict handling, JSON marshaling, and error propagation remain in place.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b194b

This localized validation change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes validation regression assertions, but the file-level changes describe batched PostgreSQL inserts generated with Squirrel builders. The title does not summarize the main changeset. Rename the pull request to describe batched relationship and attribute inserts, Squirrel query builders, or the primary storage writer change.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant