Skip to content

test(validation): add entity tuple validation regression assertions - #3133

Open
gcoinstash-cmd wants to merge 23 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788427820
Open

test(validation): add entity tuple validation regression assertions#3133
gcoinstash-cmd wants to merge 23 commits into
Permify:masterfrom
gcoinstash-cmd:test/validation-suite-tuples-1788427820

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Sep 3, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance Improvements
    • Improved the efficiency of storing relationship and attribute data by processing records in larger batches.
    • Maintained safeguards that prevent duplicate relationship records from being created.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: cf83c9a4-4924-4214-b499-135ea11eff8b

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and a3379ae.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The PostgreSQL data writer now groups relationship and attribute records into chunks of 500. It builds multi-row squirrel INSERT statements instead of queuing one statement per record. Relationship inserts retain their conflict handling.

Changes

PostgreSQL batch insert optimization

Layer / File(s) Summary
Chunked relationship and attribute inserts
internal/storage/postgres/data_writer.go
Adds _insertChunkSize = 500. batchInsertRelationships and batchInsertAttributes build multi-row INSERT statements for each chunk. Relationship inserts preserve tuple normalization and conflict handling. Attribute values remain protojson-marshaled.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to a3379

Relationship and attribute writes now use chunked multi-row PostgreSQL inserts while preserving existing conflict handling and value behavior. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes validation regression tests, but the changeset rewrites PostgreSQL relationship and attribute batch inserts with 500-row chunks and Squirrel-built multi-row INSERT statements. Rename the pull request to describe the PostgreSQL batch insert changes, or include the validation test changes described by the current title.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant