Skip to content

test(validation): add entity tuple validation regression assertions - #3134

Open
gcoinstash-cmd wants to merge 24 commits into
Permify:masterfrom
gcoinstash-cmd:test/permify-validation-coverage-1788458375
Open

test(validation): add entity tuple validation regression assertions#3134
gcoinstash-cmd wants to merge 24 commits into
Permify:masterfrom
gcoinstash-cmd:test/permify-validation-coverage-1788458375

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Sep 3, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance
    • Improved storage write performance for relationship and attribute data by processing records in batches.
    • Large data sets are now handled more efficiently, while empty collections are skipped without unnecessary processing.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 3ebf4806-4b3f-44fd-9b6a-3832c83fcec6

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and b91ea1f.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The PostgreSQL data writer now loads complete relationship and attribute collections, skips empty collections, and queues squirrel-built INSERT statements in chunks of up to 500 rows.

Changes

PostgreSQL batch insert implementation

Layer / File(s) Summary
Chunked relationship and attribute inserts
internal/storage/postgres/data_writer.go
batchInsertRelationships and batchInsertAttributes use GetTuples() and GetAttributes(), return for empty collections, and queue inserts in chunks of up to 500 rows. Relationship inserts retain the existing conflict constraint handling.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b91ea

PostgreSQL relationship and attribute writes now use bounded multi-row inserts while preserving empty-input handling and relationship conflict behavior. No current merge-readiness risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes validation regression tests, but the changeset updates PostgreSQL relationship and attribute batch inserts. The title does not describe the implemented change. Rename the pull request to describe the PostgreSQL batch insert changes, such as "refactor(postgres): batch relationship and attribute inserts".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant