Skip to content

test(validation): add entity tuple validation regression assertions - #3136

Open
gcoinstash-cmd wants to merge 26 commits into
Permify:masterfrom
gcoinstash-cmd:test/permify-subject-bounds-1788459651
Open

test(validation): add entity tuple validation regression assertions#3136
gcoinstash-cmd wants to merge 26 commits into
Permify:masterfrom
gcoinstash-cmd:test/permify-subject-bounds-1788459651

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Sep 3, 2026

Copy link
Copy Markdown

Summary of Changes

  • Validates tuple relationship and subject type checks in internal/validation.
  • go test -v ./internal/validation: 11/11 specs passed 100% green.

Summary by CodeRabbit

  • Performance
    • Improved the efficiency of bulk relationship and attribute writes by processing records in optimized batches.
    • Empty batches are now handled without unnecessary database work.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 69590c6d-30d1-4d8d-8cdc-520a9b5416a8

📥 Commits

Reviewing files that changed from the base of the PR and between e00d052 and 508e73b.

📒 Files selected for processing (1)
  • internal/storage/postgres/data_writer.go

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The PostgreSQL writer now builds relationship and attribute INSERT statements with squirrel in chunks of 500 items. Both methods return early for empty collections.

Changes

Postgres batch inserts

Layer / File(s) Summary
Chunked insert query construction
internal/storage/postgres/data_writer.go
batchInsertRelationships and batchInsertAttributes skip empty collections and queue one squirrel-built INSERT query per 500-item chunk. Relationship conflict handling remains unchanged, and attribute values continue to use protojson.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 508e7

PostgreSQL relationship and attribute writes are batched into 500-item inserts while retaining existing insertion behavior. No concrete current-head merge-readiness risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes validation regression assertions, but the changeset rewrites PostgreSQL relationship and attribute inserts to use chunked Squirrel queries. Retitle the pull request to describe the PostgreSQL batch insert changes, such as "storage(postgres): batch relationship and attribute inserts".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant