Train160: JSON, embedding, source pooling, minsize, and Unicode iteration - #10082
Merged
Merged
Conversation
added 16 commits
September 11, 2026 17:33
|
Important Review skippedToo many files! This PR contains 853 files, which is 553 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (883)
📒 Files selected for processing (853)
You can disable this status message by setting the |
proggeramlug
marked this pull request as ready for review
September 11, 2026 17:09
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composition
Audited merge train for:
for...ofThe branch contains 14 author commits with preserved authorship plus two separate maintainer commits: align the new registration package with the #10052 workspace version
0.5.1534, and remove a duplicate scopedactions/setup-nodestep created by composing #10053 with #10076. The retained Node step pins.node-versionand explicitly verifies it before native builds.The only cherry-pick conflicts were scoped-suite selector hunks in
test.yml; the final selector is the union of the two incoming suites and the already-landed Train159 suites. The #10052 evidence archive accounts for the large diff (1,736 files total); its 1,700 indexed payloads, hashes, compressed streams, raw trial counts, and recomputed summaries were audited before composition.Exact validation
Validated head
062df32d88279d90f71e4651c9bd4f4e5e17890d, tree3ab2af51176d8a2e0bbceec6ec99c40c09744c18, on exact mainf6c6879613c0b00b5e3ae873b8d102710d2d0585/ tree48d71715f50fce6d4ec1c64b6ba5388778889aaf.-D warningschecks pass.For #10052, a fresh same-host/same-graph A/B against a baseline built from a tree byte-identical to current main used identical sources/flags, randomized interleaving, two discarded and five retained fresh-process samples. Median CPU per call improves ~91% for literal/dynamic ±0 and 62% for changing-input zero; plain/pretty/keys/callback/changing-plain controls remain within 1.7%. All outputs/checksums match Node and moving/protected GC witnesses are live.
Hosted CI attribution
Run
34626023828is on the exact validated head. Product/host Clippy, API-doc regeneration/drift, both warning scopes, dependency/security checks, all 82 non-freshness lint gates, the shared gap build, and the shared GC-stress build pass. Its lint failure is solely the public-benchmark freshness red independently reproduced on exact basef6c6879613c; its cargo-test failure is solelynative_stack::tests::stack_top_respects_custom_thread_stack_sizes, with the same assertion and only failure in the exact-base scheduled run34623934322. The remaining long matrix fan-out was still running at landing; the canonical guide does not hold a locally validated train for CI.Landing ledger
Pre-push refresh confirms all five originals remain open, undrafted, and at the exact composed heads. After exact-tree landing, close each original with a pointer to this train and verify its state. Live closing-reference parsing finds only #10080 → #10062; issue #10062 was individually inspected as the genuine one-to-one Unicode iteration defect.
Closes #10062