Merge train 186r: #10223 #10234 #10235 #10237 #10238 #10239 #10240 - #10247
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (62)
📝 WalkthroughWalkthroughThe pull request updates worker resolution, lexical TDZ allocation, HTTP listen parsing, garbage-collection tracing diagnostics, macOS application bundles, native widget padding, release metadata, documentation, and regression coverage. ChangesWorker path resolution
Lexical TDZ allocation
HTTP listen parsing
Garbage collection
macOS bundles and widgets
Release and documentation updates
Estimated code review effort: 5 (Critical) | ~90 minutes Change: Other · Severity of issue fixed: Medium ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merge train 186r — seven audited PRs cherry-picked onto
main(9fda98d), plus one train fix and the version bump to 0.5.1564.Train commit:
fix(compile): fix(macos): emit app bundles for local UI builds #10240'semit_sandbox_sidecartakesexe_pathbut only the macOS arm uses it, so its PR CI failed-D warnings(cargo check -p perry --bins) on Linux withunused variable: exe_path. The non-macOS arm now consumes it.Validation (macOS, release, one target pool; per-PR CI attributed for the full gap/gc-stress/cargo-test tiers):
perry-runtime --librun — fix(macos): emit app bundles for local UI builds #10240 changes no runtime code, and the local runtime suite is clean. fix(http): preserve listen arguments in dynamic server dispatch #10238's run turnstest_gap_gc_http2_pending_event_callback_rootinggreen.scripts/run_lint_gates.sh: 80/83, the same three steps that fail onmain. Raw-handle (bare +--no-raise-vs), runtime-root holders (full + self-test), shape census, store-site inventory, test registration pass;check_thread_locals.pyreports only main'sregex/perex_owner.rs.cargo test --release: perry-codegen 2031 passed; perry-hir pass; perry-runtime 3796 passed + main's release-onlyheap_generation::a_free_or_move_outside_every_scope_is_caught_in_debug_builds(includes the newlarge_array_slotsandrestore_coveragetests); perry-ext-http 89 passed;perry --bin perry1113 passed; perry-ui-macos incl.native_widget_padding.loop_lexical_tdz,issue_10236_worker_path_await_helper,issue_9744_static_worker_helpers,issue_6185_thread_worker_closure_guards,issue_worker_threads_cross_thread_delivery,macos_app_bundle;scripts/test-loop-lexical-tdz.mjsoracle pass.--seeded-violations 40and--unrooted-allocas): pass.tdz,lexical,loop,closure: pass.Summary by CodeRabbit
New Features
.appbundles with metadata, assets, localization, and supported sidecars.Bug Fixes
listen()argument handling across HTTP, HTTPS, and HTTP/2.Documentation
Chores