Skip to content

ci(docs): remove permanently red catalog freshness check #10972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
proggeramlug wants to merge 2 commits into from
Closed

ci(docs): remove permanently red catalog freshness check #10972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
821027a
ci(docs): validate catalogs without forced regeneration
Sep 22, 2026
8d9cf70
docs(changelog): note catalog validation gate
Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/docs-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ env:
MDBOOK_VERSION: v0.5.4

jobs:
build-and-freshness:
build-and-validation:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
Expand All @@ -53,11 +53,10 @@ jobs:
python3 scripts/check_docs.py
- name: Check TypeScript fences
run: cargo run --release --quiet -p perry-doc-tests -- --lint docs/src
- name: Check gettext catalogs are current
- name: Validate gettext catalogs
run: |
./docs/i18n.sh extract
./docs/i18n.sh sync
git diff --exit-code -- docs/po
# Translation updates require review. Regenerating here rewrites
# obsolete entries and can drop existing translations (#10955).
for catalog in docs/po/*.po; do
msgfmt --check --check-format --statistics --output-file=/dev/null "$catalog"
done
Expand Down
3 changes: 3 additions & 0 deletions changelog.d/10972-docs-catalog-validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed

- Docs checks now validate the committed gettext catalogs and build every translation without regenerating catalogs during CI. Translation refreshes remain a reviewed change, avoiding a permanently failing freshness diff and unintended loss of existing translations. (#10955)
Loading