Skip to content

Fix macOS app bundle icon and metadata fallbacks - #10983

Closed
proggeramlug wants to merge 2 commits into
mainfrom
fix/10847-macos-app-bundle-metadata
Closed

proggeramlug wants to merge 2 commits into
mainfrom
fix/10847-macos-app-bundle-metadata

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

Summary

  • Copy assets/AppIcon.icns to the macOS app bundle's Contents/Resources/ root and set CFBundleIconFile in the embedded and external plists.
  • Use [project].name for the app display name when no display name is configured, and use package.json's version when [project].version is absent.
  • Document the bundle conventions and cover the icon, metadata fallbacks, and code signature in the macOS bundle test.

Fixes #10847.

Verification

  • cargo test -p perry --bin perry macos_version_uses_package_json_when_project_version_is_missing
  • cargo test -p perry --test macos_app_bundle (with matching local archives in PERRY_RUNTIME_DIR)
  • rustfmt --check, git diff --check, and scripts/check_file_size.sh

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 345bedfa-2281-4fb8-bc2f-69adbba011c4

📥 Commits

Reviewing files that changed from the base of the PR and between c1569e2 and 76d21b6.

📒 Files selected for processing (5)
  • changelog.d/10983-macos-app-bundle-metadata.md
  • crates/perry/src/commands/compile/app_metadata.rs
  • crates/perry/src/commands/compile/bundle_macos.rs
  • crates/perry/tests/macos_app_bundle.rs
  • docs/src/ui/overview.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug

Copy link
Copy Markdown
Contributor Author

Landed on main in merge train 256 (#11018, v0.5.1638), main f5cfbff882.

Carried at head 76d21b63e1. The landed tree is byte-identical to the validated train tree (9b108dd3c9), and CI on the train head passed every job except the known public-baseline lint step: all 6 gap shards, cargo-test, e2e-scoped, gc-stress, check, warnings and security-audit green.

Trains rebase-merge, so commits get new SHAs and GitHub cannot mark this PR merged. Closed as landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local macOS .app bundle does not wire the app icon (and hardcodes version / display name)

1 participant