test(parity): classify stalled gap fixtures as timeouts - #10985
proggeramlug wants to merge 2 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe two parity fixtures no longer use local deadlines to produce boolean results. They wait for completion conditions and let the parity harness classify stalled execution as a timeout. ChangesParity fixture timeout handling
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The fixtures classify stalled behavior as timeouts instead of false output mismatches, with no actionable merge-blocking risk remaining. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on main in merge train 257 (#11039, v0.5.1640), main Carried at head This train was split by blast radius after an earlier 35-PR assembly hit five gap regressions: it carries only PRs touching no lowering path. Trains rebase-merge, so commits get new SHAs and GitHub cannot mark this merged. Closed as landed. |
Fixes #10720.
The thread-release fixture now waits for the thread count to return to its expected range. The stdin-backpressure fixture waits for the marker without turning a local deadline into a
no-markerresult, and no longer prints a fixture-watchdog result when a child stalls. The parity harness's existing timeout reports these failures as timeouts instead of output mismatches.Verification:
node --experimental-strip-types test-files/test_gap_9592_child_timeout_threads.tson macOSperrymaster), exercising the/proc/self/taskbranchnode --experimental-strip-types test-files/test_gap_9493_child_stdin_backpressure.tson macOSgit diff --checkSummary by CodeRabbit
Bug Fixes
Documentation