fix(size-report): count linker-folded symbol addresses once - #10994
proggeramlug wants to merge 2 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used all 8 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on main in merge train 257 (#11039, v0.5.1640), main Carried at head This train was split by blast radius after an earlier 35-PR assembly hit five gap regressions: it carries only PRs touching no lowering path. Trains rebase-merge, so commits get new SHAs and GitHub cannot mark this merged. Closed as landed. |
Fixes #10571.
--report-sizepreviously charged every symbol name at a folded address as another copy of the emitted bytes. That inflated crate and generic-family totals and madeduplicate-function-bodysuggest savings the linker had already achieved.This change keeps one deterministic representative per section/address before building any totals or duplicate-body groups. When aliases disagree about size, it prefers the largest real symbol size. The report now describes generic-family counts as distinct linked instantiations.
Validation:
cargo test -p perry --bin perry folded_symbol_aliases_are_charged_onceon an isolated Linux checkout at perrymaster: 1 passed.rustfmt --check --edition 2021 crates/perry/src/commands/compile/size_report.rs./scripts/check_file_size.shpython3 scripts/check_test_registration.pygit diff --check