Fix stdin listeners on node:process namespace imports - #11001
proggeramlug wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 8 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on main in merge train 258 (#11078, v0.5.1641), main Carried at head This train was bisect-verified: after an earlier 35-PR assembly hit five gap regressions, the lowering-touching PRs were split into probes, and this set (#11070) came back with all six gap shards clean while the other half reproduced all five. Trains rebase-merge, so commits get new SHAs and GitHub cannot mark this merged. Closed as landed. |
Summary
Fix literal
process.stdin.on("data"/"end", ...)calls whenprocessis a namespace import fromnode:process. The HIR lowering previously classifiedprocess.stdin.onas a native class method before reaching the process stream handler, so it registered no listeners.Allow process stream properties through to the stream handler and recognize namespace/default imports there. Scope checks preserve calls on a locally shadowed
processobject.Fixes #10914.
Testing
SHADOW undefinedandEXIT 0 false 0 0.SHADOW local,END 5 true,EXIT 0 true 5 true.cargo fmt --all -- --checkgit diff --checkscripts/check_file_size.sh