fix(runtime): accept low macOS length receivers - #11055
proggeramlug wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 8 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Held from merge train 259 by the GC store-site inventory gate: This PR is the only one in the train touching that file. The gate wants a marker classifying the write, in the accepted form Please pick the class deliberately rather than whichever one silences it: the classification is the documentation of why that raw write is safe, and a wrong class is worse than none. If the slot can hold a heap pointer and the write is not through a barrier, that's a real finding rather than a paperwork step. Everything else about the PR was fine in the train — no conflict, and all other gates green. Ping me when it's marked and it rides the next train. |
|
One required step is red, and it is deliberately asking you a question I should not answer for you: The gate's self-test passed in the same run, so the finding is trustworthy: it is the new raw I am not going to pick the class for you, and I'd push back on anyone who did. Choosing between So, for the write at
Whichever you pick, the marker carries a reason — write the one you would want to read in six months. Everything else on this PR is green. (Edited: my first version of this comment had three code spans eaten by shell expansion before posting.) |
(cherry picked from commit 07a1c95)
|
Landed on Four of this train's seven PRs — including this one, if it is #11055, #11023, #11012 or #11014 — were repaired here because they were stuck: the fixes were cherry-picked from A train rebase gives the commits new SHAs, so GitHub cannot auto-close the source PR; closing by hand. Nothing needed from you. |
Fixes #10271.
Summary
Validation