bench(packages): package matrix re-run after the fixing phase - #11723
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (14)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-run of the package-performance matrix (
benchmarks/packages/,scripts/package_bench.py, from #11466) to close the fixing phase. Data and docs only: no compiler, runtime or harness change, and no version bump.Commit measured:
9e29f59d43(the merge of #11645) on both hosts. Perry was built from that commit separately on each host.36420d2e56.Summary (details, the full before/after matrix and the attribution are in
benchmarks/packages/RERUN-2026-09-30.md):mongodb/insert_find(mongodb 7.6.0: insertOne after deleteMany rejects with "reading 'state'" and the process hangs #11460,known_hang) now runs correctly. 2 Perry failures remain, and both have package-free repros in the doc:node-forge/rsa_sign:thisis undefined inside ado…whilebody in non-class functions.fastify/inject:assignSocketis a no-op on a CJSutil.inheritssubclass ofServerResponse.origin/main9e05951071. Issues have not been filed yet.#x/#m()are ~1,200× slower than Node, 130× slower than public (marker-string format + by-name brand lookup per access) #10501)obj.method()through the runtime dispatcher is ~3,000× slower than Node (two O(own-keys) string-compare scans per call before any cache) #10502, perf: function-constructor objects (new F(),x instanceof F) are 78–566× slower than Node (F.prototype and builtin identity re-derived from side tables per operation) #10507)Files:
results/*.json,REPORT.mdandreport_notes.mdare regenerated the way bench(packages): Phase 1 package-performance harness + first report (Perry vs Node vs Bun) #11466 stored them. The previous versions are in git history at24a5262bd6.profile/rerun-2026-09-30/: call-graph attribution for the top six workloads plusmongodb/insert_find.RERUN-2026-09-30.md: the before/after comparison and the re-ranking.Not run or not done:
--callgraphsweep; only the top offenders were profiled.PROFILE.mdstill describes the36420d2e56attribution.mongodb/insert_findis still markedknown_hangin the manifest. It was measured separately with--include-known-hangsat the same commit.check_file_size.sh. The diff touches onlybenchmarks/packages/**andchangelog.d/.