Repository navigation
[Contracts] Remove deleted and removed gist ids from the per-cell index #1425
Description
Found in a repository audit of
main(b472e6b). The facts below were checked against that commit.
Problem
delete_gist and remove_gist remove DataKey::Gist(id) but never touch DataKey::CellIndex(cell) (the key is referenced only when posting and listing). Dead ids accumulate forever, and list_gists_by_cell keeps iterating over them.
Fix
Load the gist's location_cell before removing it and remove its id from the cell's vector. Add tests that delete or remove a gist and check the index no longer contains it.
Acceptance criteria
- Both delete paths prune the index
- A test asserts listing and pagination after a delete
- No other index behaviour changes
Notes
Scope: Light (about half a day or less). Location: contracts/src/lib.rs.
Activity
guptakumarranjeet150 commentedon Oct 14, 2026
Hi team,
I analyzed "[Contracts] Remove deleted and removed gist ids from the per-cell index" in PinSpace-Org/GistPin and have a concrete technical roadmap to resolve it.
Technical Implementation Outline:
Address::require_auth).Please assign this issue to me. I will submit a clean, well-tested, and production-ready PR promptly!
northersubair commentedon Oct 17, 2026
@northersubair has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @northersubair to this issue.
drips-wave commentedon Oct 17, 2026
Congratulations, @northersubair! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @northersubair: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Oct 17, 2026
🎉 This issue has been marked as completed on GrantFox!
@northersubair's PR #1525 was approved and merged by @BigBen-7.
🏆 @northersubair: You earned 40 FoxPoints for this contribution! Your current tier: Builder (2,068 total points). Track your full progress on GrantFox.
👏 Great work, @northersubair! Keep contributing to PinSpace-Org.
drips-wave commentedon Oct 17, 2026
This issue has been completed by @northersubair as part of the Stellar Wave Program's 10th Wave 🥳
😎 @northersubair: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.
northersubair: event tests for edit/delete/moderate (PinSpace-Org#1427,