Skip to content

projectsfame: cargo fmt + non-root dev image (#1421, #1422) #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigBen-7 merged 1 commit into from
Oct 17, 2026
Merged

projectsfame: cargo fmt + non-root dev image (#1421, #1422) #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Backend/Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
FROM node:20-alpine
WORKDIR /app

COPY package*.json ./
RUN npm install
COPY . .
# Install exactly what package-lock.json pins (and fail the build if the
# lockfile and package.json have drifted apart).
RUN npm ci

# Hand the source tree to the unprivileged user that ships with the node image,
# so nothing under /app is left root-owned when the process starts.
COPY --chown=node:node . .

USER node
EXPOSE 3000
CMD ["npm", "run", "start:dev"]
30 changes: 19 additions & 11 deletions contracts/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,7 @@ impl GistRegistry {
env.storage().persistent().set(&last_key, &now);
}

let gist_id: u64 = env
.storage()
.instance()
.get(&GIST_COUNT)
.unwrap_or(0u64)
+ 1;
let gist_id: u64 = env.storage().instance().get(&GIST_COUNT).unwrap_or(0u64) + 1;

let gist = Gist {
gist_id,
Expand All @@ -155,7 +150,9 @@ impl GistRegistry {
hidden: false,
};

env.storage().persistent().set(&DataKey::Gist(gist_id), &gist);
env.storage()
.persistent()
.set(&DataKey::Gist(gist_id), &gist);
env.storage().instance().set(&GIST_COUNT, &gist_id);

// --- secondary index by cell (#875) --------------------------------
Expand Down Expand Up @@ -326,7 +323,9 @@ impl GistRegistry {
pub fn edit_gist(env: Env, gist_id: u64, new_content_hash: String) -> Result<(), GistError> {
let mut gist = Self::load_authored(&env, gist_id)?;
gist.content_hash = new_content_hash;
env.storage().persistent().set(&DataKey::Gist(gist_id), &gist);
env.storage()
.persistent()
.set(&DataKey::Gist(gist_id), &gist);
env.events()
.publish((Symbol::new(&env, "gist_edited"),), gist);
Ok(())
Expand Down Expand Up @@ -383,7 +382,9 @@ impl GistRegistry {
.get(&DataKey::Gist(gist_id))
.ok_or(GistError::NotFound)?;
gist.hidden = hidden;
env.storage().persistent().set(&DataKey::Gist(gist_id), &gist);
env.storage()
.persistent()
.set(&DataKey::Gist(gist_id), &gist);
Ok(())
}
}
Expand Down Expand Up @@ -644,7 +645,12 @@ mod tests {
let env = Env::default();
let client = setup(&env);

assert_eq!(client.list_gists_by_cell(&cell(&env, "nope"), &0, &10).len(), 0);
assert_eq!(
client
.list_gists_by_cell(&cell(&env, "nope"), &0, &10)
.len(),
0
);
}

// -- initialization / moderator (#878) -----------------------------------
Expand Down Expand Up @@ -696,7 +702,9 @@ mod tests {
// excluded from listings and inactive, but still auditable
assert_eq!(client.list_gists_by_cell(&location, &0, &10).len(), 0);
assert!(!client.is_active(&id));
let gist = client.get_gist(&id).expect("hidden gist is still retrievable");
let gist = client
.get_gist(&id)
.expect("hidden gist is still retrievable");
assert!(gist.hidden);

client.unhide_gist(&id);
Expand Down