chore(baseline): resync the tui changelog slice, surface facts, and test clippy - #60
Merged
asto18089 merged 4 commits intoSep 17, 2026
Conversation
…est clippy Split out of CodeWhale#56 per CONTRIBUTING.md: changelog entries are written on main at merge time and PRs carrying changelog hunks are asked to strip them, so the DDG-to-Bing degradation entry (behavior already merged in Hmbown#44 via ff299f9; the root CHANGELOG already carried it, the packaged tui slice did not) moves here together with its generated web twin. The surface-facts trio moves with it because no gate on the pinvou3-clean lane checks them; note v0.9.13 published on 2026-09-14, so the next receipts run should refresh latestPublishedRelease again. The redundant-closure cleanup in engine/tests.rs rides here because it blocks the master/main and release lint lanes, not the fork lane. Signed-off-by: asto18089 <asto18089@126.com>
|
Thanks @asto18089 for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
The surface-facts contract interpolated latestPublishedRelease.version into a required 'published <version> release asked first' phrase. Once the pin moves to v0.9.12 that demanded phrase becomes false: 0.9.12 counts by default and never asked. Name the historically fixed asking release instead, matching the contract's upstream evolution: prose says 'earlier 0.9.11 release asked first' (en + zh), the test asserts it as a literal, and the roadmap/faq/telemetryLead copies follow. Catalogs regenerated with npm run i18n:gt -- export; npm test 407/407 green. Signed-off-by: asto <asto18089@126.com>
Review follow-up: the telemetry trust prose this PR evolves is mirrored
across the en/zh dictionaries and the faq/roadmap pages with no test
anchor, so a future edit could update one face and silently leave the
others behind. Assert the fixed 'earlier 0.9.11 release asked first'
phrasing (and its zh mirror) in every face and reject the interpolated
'published 0.9.11' wording; make providerCountDefinition version-free
('the providers of any published release') so the same stale-pin drift
cannot recur there; refresh the stale comment above the telemetry
assertions.
Signed-off-by: asto18089 <asto18089@126.com>
JensenChen28
approved these changes
Sep 17, 2026
JensenChen28
left a comment
Collaborator
There was a problem hiding this comment.
已审查当前 head 对目标分支的实际差异,未发现需要阻塞合入的问题;提交前重新确认 required checks 通过。核对了发布事实、文案及生成内容一致性变更。本轮以静态审查和远端门禁为依据,未在本机运行完整 Rust workspace 或所有平台测试。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CodeWhale#56 originally carried three disclosed baseline repairs that do not belong on a topic branch:
crates/tui/CHANGELOG.md[Unreleased]slice was missing the DDG→Bing search-degradation entry that the rootCHANGELOG.mdhas carried since docs(changelog): record keyless Bing search tail #39 recorded it (3f8a25eef) for the search degradation merged with build: re-fork Pinvou on v0.9.12 #44 (ff299f94b) — behavior already merged on base, purely a forgotten slice resync;docs/public-surface-facts.json,web/data/latest-published-release.json,web/lib/facts.generated.ts), whileweb/lib/changelog.generated.tswas missing the new[Unreleased]entry;crates/tui/src/core/engine/tests.rscarried amap(|event| Ok(event))redundant-closure that the master/main and release lint lanes (--all-targets -D warnings) reject.CONTRIBUTING.md writes changelog entries on main at merge time and asks PRs carrying changelog hunks to strip them; #56 has now stripped all of these (18f7c7b) and this PR is their dedicated home. A single-purpose chore touching only these files also avoids the merge-conflict churn the policy exists to prevent.
Notes
evolve together (2b1784c): the baseline test interpolated
latestPublishedRelease.versioninto a required "publishedrelease asked first" phrase, which would demand a false claim for 0.9.12
(it counts by default and never asked). Following the contract's upstream
evolution, the prose and the roadmap/faq/telemetryLead copies (en + zh) now
name the historically fixed asking release — "earlier 0.9.11 release asked
first" — and the test asserts it as a literal. Catalogs regenerated via
npm run i18n:gt -- export;npm testpasses 407/407.latestPublishedReleaseagain. No gate on thepinvou3-cleanlane checks these files (the web freshness checks trigger on master/main only), so this PR does not claim to satisfy them.providerCountDefinitionis now version-free ("the providers of any published release") so the same stale-pin drift cannot recur there.npm testpasses 408/408 at head.No-Issue: baseline housekeeping split from fix(fork): stop naming absent tools in model-facing text #56; no separate issue tracked.