Skip to content

chore(baseline): resync the tui changelog slice, surface facts, and test clippy - #60

Merged
asto18089 merged 4 commits into
Pinvou:pinvou3-cleanfrom
asto18089:chore/baseline-gate-repairs
Sep 17, 2026
Merged

asto18089 merged 4 commits into
Pinvou:pinvou3-cleanfrom
asto18089:chore/baseline-gate-repairs

Conversation

@asto18089

@asto18089 asto18089 commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

CodeWhale#56 originally carried three disclosed baseline repairs that do not belong on a topic branch:

  • the crates/tui/CHANGELOG.md [Unreleased] slice was missing the DDG→Bing search-degradation entry that the root CHANGELOG.md has carried since docs(changelog): record keyless Bing search tail #39 recorded it (3f8a25eef) for the search degradation merged with build: re-fork Pinvou on v0.9.12 #44 (ff299f94b) — behavior already merged on base, purely a forgotten slice resync;
  • the generated web twins still described v0.9.11 (docs/public-surface-facts.json, web/data/latest-published-release.json, web/lib/facts.generated.ts), while web/lib/changelog.generated.ts was missing the new [Unreleased] entry;
  • crates/tui/src/core/engine/tests.rs carried a map(|event| Ok(event)) redundant-closure that the master/main and release lint lanes (--all-targets -D warnings) reject.

CONTRIBUTING.md writes changelog entries on main at merge time and asks PRs carrying changelog hunks to strip them; #56 has now stripped all of these (18f7c7b) and this PR is their dedicated home. A single-purpose chore touching only these files also avoids the merge-conflict churn the policy exists to prevent.

Notes

  • Pinning v0.9.12 forced the telemetry trust prose and its contract test to
    evolve together (2b1784c): the baseline test interpolated
    latestPublishedRelease.version into a required "published
    release asked first" phrase, which would demand a false claim for 0.9.12
    (it counts by default and never asked). Following the contract's upstream
    evolution, the prose and the roadmap/faq/telemetryLead copies (en + zh) now
    name the historically fixed asking release — "earlier 0.9.11 release asked
    first" — and the test asserts it as a literal. Catalogs regenerated via
    npm run i18n:gt -- export; npm test passes 407/407.
  • The facts refresh pins v0.9.12 (published 2026-09-05). v0.9.13 published 2026-09-14, after this refresh was generated; the next release-manager receipts run should bump latestPublishedRelease again. No gate on the pinvou3-clean lane checks these files (the web freshness checks trigger on master/main only), so this PR does not claim to satisfy them.
  • A review pass added ead3874: the asking-release prose mirrored across the en/zh dictionaries and the faq/roadmap pages had no test anchor, so a new contract test asserts the fixed phrasing in every face and rejects the interpolated "published 0.9.11" wording, and providerCountDefinition is now version-free ("the providers of any published release") so the same stale-pin drift cannot recur there. npm test passes 408/408 at head.
    No-Issue: baseline housekeeping split from fix(fork): stop naming absent tools in model-facing text #56; no separate issue tracked.

…est clippy

Split out of CodeWhale#56 per CONTRIBUTING.md: changelog entries are
written on main at merge time and PRs carrying changelog hunks are asked
to strip them, so the DDG-to-Bing degradation entry (behavior already
merged in Hmbown#44 via ff299f9; the root CHANGELOG already carried it, the
packaged tui slice did not) moves here together with its generated
web twin. The surface-facts trio moves with it because no gate on the
pinvou3-clean lane checks them; note v0.9.13 published on 2026-09-14,
so the next receipts run should refresh latestPublishedRelease again.
The redundant-closure cleanup in engine/tests.rs rides here because it
blocks the master/main and release lint lanes, not the fork lane.

Signed-off-by: asto18089 <asto18089@126.com>
@github-actions

Copy link
Copy Markdown

Thanks @asto18089 for taking the time to contribute.

This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered.

Please read CONTRIBUTING.md for the expected contribution shape. A maintainer can grant recurring PR access by commenting /lgtm on a pull request.

The surface-facts contract interpolated latestPublishedRelease.version
into a required 'published <version> release asked first' phrase. Once
the pin moves to v0.9.12 that demanded phrase becomes false: 0.9.12
counts by default and never asked. Name the historically fixed asking
release instead, matching the contract's upstream evolution: prose says
'earlier 0.9.11 release asked first' (en + zh), the test asserts it as
a literal, and the roadmap/faq/telemetryLead copies follow. Catalogs
regenerated with npm run i18n:gt -- export; npm test 407/407 green.

Signed-off-by: asto <asto18089@126.com>
Review follow-up: the telemetry trust prose this PR evolves is mirrored
across the en/zh dictionaries and the faq/roadmap pages with no test
anchor, so a future edit could update one face and silently leave the
others behind. Assert the fixed 'earlier 0.9.11 release asked first'
phrasing (and its zh mirror) in every face and reject the interpolated
'published 0.9.11' wording; make providerCountDefinition version-free
('the providers of any published release') so the same stale-pin drift
cannot recur there; refresh the stale comment above the telemetry
assertions.

Signed-off-by: asto18089 <asto18089@126.com>

@JensenChen28 JensenChen28 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已审查当前 head 对目标分支的实际差异,未发现需要阻塞合入的问题;提交前重新确认 required checks 通过。核对了发布事实、文案及生成内容一致性变更。本轮以静态审查和远端门禁为依据,未在本机运行完整 Rust workspace 或所有平台测试。

@asto18089
asto18089 merged commit 889fc2f into Pinvou:pinvou3-clean Sep 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants