Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the existing Maven publisher, which runs repository build code with publication/signing credentials, with the protected shared PlaytikaOSS workflow. The caller pins shared commit
414efe1258d11ba5dcd2f9de4a9fcf82bd915c38; review and merge playtika-workflows #6 before enabling it.The shared workflow verifies the exact release tag commit on protected
main, approved actors and the protected Environment. It builds without publication secrets, attests the unsigned bundle, and rechecks authorization/provenance after independent approval before the official JReleaser action signs and publishes. The publisher runs no caller build code and has no GitHub write token. Manual publication and release-time source pushes are removed.Repository configuration: JDK 8, Maven group
com.playtika.graphqlcodegen, example taggraphqlcodegen-maven-plugin-1.13→ Maven version1.13, Environment tag-only policygraphqlcodegen-maven-plugin-[0-9]*.[0-9]*. Release tests run in the credential-free build job.Add the Apache Maven 3.3.4 script-only wrapper with SHA-256 verification of the pinned Maven 3.9.16 distribution.
Preserve prefixed two-component tags (
graphqlcodegen-maven-plugin-1.13→ Maven1.13) and attach source/Javadoc JARs required for Central.Replace retired
actions/cache@v1CI with pinned official checkout/setup-java actions and setup-java Maven caching; CI verifies tests and publication artifacts with Maven signing disabled.Validation: caller policy execution, input/pin/permission checks, XML parsing, actionlint and diff checks passed. The shared workflow's 20 security regression tests pass locally and in GitHub Actions. Local Maven version update and unsigned file-repository deployment passed on JDK 8, staging 4 POM/JAR artifacts. Tests were skipped for that staging check. Staged POM coordinates, source/Javadoc companion artifacts and the fixed publisher's archive validation passed.
Before enabling releases, follow
.github/RELEASING.md: configureRELEASE_ACTORS, protected branch/version tags, and amaven-centralEnvironment with independent reviewers, self-review prevention, administrator bypass disabled, the exact tag policy above and all five publication/signing secrets. Remove repository-level copies and exclude this repository from organization copies of those secrets. This PR remains a draft until the shared dependency, onboarding and required CI are reviewed.The official JReleaser 1.26.0 signing and packaging dry run also passed with a disposable test key and dummy credentials. No live Central deployment was performed.