Restore Cloud Run metadata gzip compression#3711
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3711 +/- ##
==========================================
- Coverage 78.87% 78.81% -0.06%
==========================================
Files 71 71
Lines 4318 4320 +2
Branches 804 804
==========================================
- Hits 3406 3405 -1
- Misses 698 702 +4
+ Partials 214 213 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3710
Summary
/us/metadata, are transported compressed without changing the JSON payload shape.Why
The Stage 3 Cloud Run staging integration run failed because
/us/metadataexceeded Cloud Run's uncompressed response-size limit. The app logged200 OK, but Cloud Run returned500withResponse size was too large.This keeps the existing endpoint contract intact: callers like
policyengine-app-v2can continue using normalfetch(...).json()with no custom decompression or framing.Validation
uv run pytest tests/unit/test_asgi_factory.py::test_large_flask_fallback_response_supports_http_gzipuv run ruff check tests/unit/conftest.py policyengine_api/asgi_factory.py tests/unit/test_asgi_factory.pyuv run ruff format --check tests/unit/conftest.py policyengine_api/asgi_factory.py tests/unit/test_asgi_factory.pyfetchcheck against the patched ASGI wrapper confirmedfetch(...).json()receives decoded JSON while the transport response usesContent-Encoding: gzip.