Repository navigation
feat(app): add config.allowMultiOrgCreation to expose ALLOW_MULTI_ORG_CREATION - #228
Open
naresh4dev wants to merge 1 commit into
Open
naresh4dev wants to merge 1 commit into
naresh4dev wants to merge 1 commit into
Conversation
albus PR #2799 added an opt-in ALLOW_MULTI_ORG_CREATION flag that lets users who are already an owner/admin of an organization create additional ones. The chart had no way to set it, so air-gapped installs had to fall back to backend.deployment.extraEnv. Expose it as config.allowMultiOrgCreation, rendered as an else-if branch of the existing disableOrgCreation block so DISABLE_ORG_CREATION keeps precedence. This mirrors the backend, where isMultiOrgCreationEnabled requires DISABLE_ORG_CREATION !== 'ON'.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The OpenShift sample’s pinned backend version ignores the newly documented environment variable.
1 open finding
What changed in this PR
Exposes multi-organization creation as a first-class Helm configuration option while preserving existing defaults and disable precedence.
Changes:
- Adds and renders
config.allowMultiOrgCreation. - Documents flag behavior and precedence.
- Updates the chart version and OpenShift sample.
| File | Description |
|---|---|
values.yaml |
Adds the disabled-by-default value. |
templates/backend/deployment.yaml |
Renders the backend environment variable. |
docs/configuration.md |
Documents organization creation controls. |
config-samples/openshift.yaml |
Adds the option, but pins an incompatible older backend. |
Chart.yaml |
Bumps the chart patch version. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| config: | ||
| jwtPrivateKey: "" # Required: set a strong secret for signing the frontend JWT tokens, or provide it via config.existingSecretName | ||
| disableOrgCreation: false # Set to true to disable organization creation post installation and first time login | ||
| allowMultiOrgCreation: false # Set to true to let org owners/admins create additional organizations. Ignored when disableOrgCreation is true |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
albus#2799 added an opt-in
ALLOW_MULTI_ORG_CREATIONbackend flag that lets users who are already anowner/adminof an organization create additional ones. The chart had no way to set it, so air-gapped installs had to fall back tobackend.deployment.extraEnv.This exposes it as
config.allowMultiOrgCreation.Motivation and Context
In an air-gapped deployment the first organization is self-provisioned over HTTP (
POST /v2/auth/login→POST /v1/organisation) — there are no seeds or migrations that insert an initial org. Once a user owns an org, the "You are already part of an organisation and cannot create a new one" guard blocks any further orgs.ALLOW_MULTI_ORG_CREATIONis the supported escape hatch for operators who need multiple orgs on one install, and it should be a first-class chart value rather than a raw env override.Changes
values.yaml— newconfig.allowMultiOrgCreation: false(default preserves current behaviour)templates/backend/deployment.yaml— rendered as anelse ifbranch of the existingdisableOrgCreationblock, soDISABLE_ORG_CREATIONkeeps precedencedocs/configuration.md— new "Organization Creation" section documenting both flags and their interactionconfig-samples/openshift.yaml— added the key with an explanatory commentChart.yaml— version1.7.6→1.7.7Why
else ifand not a second independent blockThe backend already treats these as mutually exclusive:
Rendering
ALLOW_MULTI_ORG_CREATION=ONalongsideDISABLE_ORG_CREATION=ONwould be a no-op that reads as if multi-org were active. Theelse ifmakes the precedence explicit in the manifest.How Has This Been Tested?
helm lintpasses.helm templateverified for all four flag combinations:disableOrgCreationallowMultiOrgCreationfalsefalsefalsetrueALLOW_MULTI_ORG_CREATION=ONtruefalseDISABLE_ORG_CREATION=ONtruetrueDISABLE_ORG_CREATION=ONonlyFull chart render (33 resources) and the
openshift.yamlsample both render cleanly.helm lint+helm templatematrix across all flag combinationsTypes of changes
Change Size
Checklist
Code Quality
Documentation
Backward Compatibility and Dependencies
Defaults to
false, so existing installs render byte-identical manifests. Requires anappVersionthat includes albus#2799; on older backends the env var is simply ignored.Deployment Notes
Operators who previously set
ALLOW_MULTI_ORG_CREATIONviabackend.deployment.extraEnvcan move it toconfig.allowMultiOrgCreation. Leaving it inextraEnvcontinues to work.