Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The configuration, template rendering, defaults, and documentation are consistent and complete.
0 open findings
What changed in this PR
Adds support for globally verified email domains in backend authentication workflows.
Changes:
- Adds configurable verified domain lists with wildcard support.
- Exposes domains through
VERIFIED_EMAIL_DOMAINS. - Documents configuration and behavior.
| File | Description |
|---|---|
charts/portkey-app/values.yaml |
Adds the domain configuration. |
charts/portkey-app/templates/_helpers.tpl |
Renders the backend environment variable. |
charts/portkey-app/docs/sso-setup.md |
Documents setup and supported use cases. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+150
to
+151
| - path: oauthVerifiedEmailDomains | ||
| objectAlias: oauthVerifiedEmailDomains |
| These domains: | ||
|
|
||
| * Are passed to the backend as the comma-separated `VERIFIED_EMAIL_DOMAINS` environment variable. This works with or without `config.existingSecretName`. | ||
| * Can alternatively come from a secret: leave `verifiedEmailDomains` empty and add an `oauthVerifiedEmailDomains` key (e.g. `acme.com,*.acme.io`) to the chart Secret / `existingSecretName` / your secret manager. If both are set, the `values.yaml` list wins. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.