Repository navigation
Shorter SCANFI download errors that name the server that failed - #276
Merged
Merged
Conversation
The message decided "Drive or mirror" from the options alone, so a user with their own reproducible.urlRemap was told to check that urlRemap is non-NULL (it was) and to enable LandR.scanfiMirror (it was). It now reads the error: a Google Drive error is a Drive access problem, otherwise a remapped V2 url is a mirror (network) problem. The mirror advice names the setting that applies, and the message is about half as long. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eliotmcintire
added
enhancement
eliotmcintire
added a commit
that referenced
this pull request
Oct 16, 2026
Brings in #276: shorter SCANFI access errors that name the server that failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # NEWS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a SCANFI download failed, LandR printed a long error that could give the wrong advice: someone who already had a mirror set up was told to turn the mirror on. The error is now about half as long, says whether Google Drive or the mirror refused the file, and only suggests settings that would actually change something.
Affects: the text of SCANFI download errors only; no download behaviour changes.
Technical details
.scanfiAccessMessage()(R/scanfi-access.R) chose between the Drive and mirror text with.remapsToMirror(), which returns FALSE whenever the user has their ownreproducible.urlRemap. That user then got "check that ...getOption("reproducible.urlRemap")[is] non-NULL" and "permissions problem", even when their remap covered the file (the case wherepreProcess()ignored the remap, fixed in PredictiveEcology/reproducible#648).Now: an error that mentions Google Drive is reported as a Drive access problem; otherwise a url the remap sends to the mirror is reported as a mirror (network) problem. For a V2 Drive failure the mirror bullet is "check that your
reproducible.urlRemapcovers this file" when the user has a remap, "setoptions(LandR.scanfiMirror = TRUE)" when the mirror is off, and absent when it was already on. Bullets are no longer wrapped, and the intro is one sentence.Tests in
test-scanfi-access.Randtest-scanfiMirror.Rupdated, plus a new test of the three mirror-advice cases and of a Drive error on a url the mirror covers. This PR targetsarbutus-scanfi(#274), where this message code lives;modsForFireSensewill need it merged in too.🤖 Generated with Claude Code