Repository navigation
Defaults: re-score every 10 generations, drop bad hosts, wait 8 h for cores - #53
Merged
Merged
Conversation
…, waitForCores to 8 hours The three options FireSense production already sets are now the defaults, defined once in .optionDefaults. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ded @inheritParams on freeCoresLessReserved Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #53 +/- ##
============================================
Coverage 74.09% 74.09%
============================================
Files 21 22 +1
Lines 2061 2061
============================================
Hits 1527 1527
Misses 534 534 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
eliotmcintire
added a commit
that referenced
this pull request
Oct 14, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three settings that FireSense runs have always set by hand now take those values by default: DEoptim re-scores its surviving population periodically, a host that fails checks is left out instead of stopping the job, and a job waits for busy cores instead of failing. In the FireSense comparison, re-scoring converged in about half the generations and reached the best scores without lucky draws.
Affects: DEoptim runs that never set
clusters.deoptimRescoreEverynow re-score every 10 generations, builds that never setclusters.onBadHostdrop failing hosts, and builds that never setclusters.waitForCoreswait up to 8 hours for cores.Technical details
The defaults were hard-coded where read: R/DEoptim.R:253-254 (unset meant 0), R/estimateCluster.R:293 ("stop"), R/allocateWhenAvailable.R:41, R/estimateCluster.R:369 and R/reserveCapacity.R:55 (0). They now come from one list,
.optionDefaultsin R/optionDefaults.R, read with.clustersOption(); explicit settings, including 0, still win. New tests: tests/testthat/test-optionDefaults.R and the default-10 test in test-DEoptimRescore.R (both fail on development). The test setup setsclusters.waitForCores = 0so tests that expect an immediate shortfall error do not wait 8 hours. R CMD check on the branch: 0 errors, 0 warnings, 3 existing notes, all tests pass.Also fixed the two
devtools::document()errors: in R/clusters.R the@export/@importFromtags sat inside\dontrun{}(soplotMachine()andtestMachine()were never exported and are now), and R/reservations.R had an@inheritParamsforfreeCoresLessReserved()that inherited nothing, now removed.🤖 Generated with Claude Code