Repository navigation
runDEoptim(convergence =): stopping rule as a fit setting in the cache key - #162
Merged
Merged
Conversation
… and, when not NULL, the fit's cache key clusters floor 0.0.80. Depends-on: PredictiveEcology/clusters#55 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #162 +/- ##
===============================================
- Coverage 89.18% 89.14% -0.04%
===============================================
Files 50 50
Lines 4409 4413 +4
===============================================
+ Hits 3932 3934 +2
- Misses 477 479 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
eliotmcintire
added a commit
that referenced
this pull request
Oct 17, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fits sometimes stop while still improving. The stopping rule becomes a fit setting that the fit's cache sees, so a stopped fit can be continued with a stricter rule.
Affects: nothing changes unless
convergenceis given; leaving it out keeps existing cached fits valid.Depends-on: PredictiveEcology/clusters#55
Technical details
runDEoptim()had no way to pass the early-stop settings toclusters::DEoptimIterative()(R/DEoptim_fns.R, theCache(clusters::DEoptimIterative(...))call). New argumentconvergence = NULLis passed through; whenNULLit is inomitArgs(viaomitNullArgs(), ascovCentreis), so existing keys are unchanged, and when set it is in the fit's key. clusters floor 0.0.80. Tests (test-runDEoptim-convergence.R): pass-through, NULL not in the key, a set value is. The two mock helpers moved fromtest-runDEoptim-plotEvery.Rtohelper-runDEoptim-mocks.Rso both files share them. Full tests: 0 failures on the branch and on development.R CMD check --no-manual(vignettes not built): 0 errors; Rd and codoc clean; the only warnings are the unbuilt vignettes.🤖 Generated with Claude Code
https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6