Repository navigation
Never cache init: it reads the spread-fit ledger - #71
Merged
Merged
Conversation
…r files) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eliotmcintire
added
bug
eliotmcintire
added a commit
that referenced
this pull request
Oct 15, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cached start-up step could remember an out-of-date answer about whether a study area has already been fitted, and then skip or repeat the fit preparation wrongly. That step is now never served from the cache.
Affects: runs that put
initin.useCache(module or.globals) now always re-read the ledger; the usual.useCachesettings are unchanged.Technical details
Defect:
fireSense_dataPrepFit.R:347-351(init,Init()at line ~409 callsreadSpreadFitLedger()) decides from the Google Drive ledger, which is not in the event's cache key, so a cachedinitreplays a stale 'fit exists' / 'no fit yet' decision. The module now declares.neverCache, which SpaDES.core >= 3.2.1.9037 reads (.eventIsCached()) and which wins over.useCachein every form, including.globals; the SpaDES.core floor inreqdPkgsis raised to 3.2.1.9037. The newtests/testthat/test-neverCache.Rchecks the declaration and that.eventIsCached()refuses to cache the listed events even with.useCachenaming them orTRUE; it fails on development (parameter not declared) and passes here. Full module suite: 315 tests, 0 failures/errors on this branch; development has 311, 0 failures/errors.🤖 Generated with Claude Code