Repository navigation
Strictly-before vegetation rule from fireSenseUtils, not a local copy - #75
Merged
eliotmcintire merged 1 commit intoOct 16, 2026
Merged
Conversation
…move vegetationYear() Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
eliotmcintire
added
bug
eliotmcintire
added a commit
that referenced
this pull request
Oct 16, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fit's vegetation tables and the spread objective disagreed about which vegetation year a fire year uses, so spread fits failed for fire years that equal a data year. This module now states the rule through the one shared function the objective also uses.
Affects: nothing changes in the tables this module builds; it only needs the fireSenseUtils version that carries the shared rule.
Depends-on: PredictiveEcology/fireSenseUtils#159
Technical details
The module had its own
vegetationYear() = fireYears - 1L(fireSense_dataPrepFit.R:1791), a second statement of the rule that the objective in fireSenseUtils did not share. It is removed:vegetationDataYear()callsfireSenseUtils::dataYearBefore(), andlccShareForYear()andfitDecisionYearName()calldataYearElement(before = TRUE). reqdPkgs floor on fireSenseUtils is 0.2.3.9100, the version after #159 merges and is bumped; tests were run against #159's branch installed as 0.2.3.9100 in a scratch library. Behaviour is identical; the only test edits are the three lines oftest-lccShareForYear.Rthat called the removedvegetationYear(). Module tests (convertToPackage()+test_local()): development 320 passed, 1 skipped, 0 failed; branch the same.🤖 Generated with Claude Code
https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6