Repository navigation
R CMD check: clear the two notes - #77
Merged
Merged
Conversation
… reqdPkgs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eliotmcintire
added a commit
that referenced
this pull request
Oct 17, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019T7wFP7tXPDaRn42BFLzjr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module's automated package check reported one warning and two notes, all present before. This clears the two notes; the warning needs a change in another package and remains.
Affects: nothing in results; check output only.
Technical details
Causes and fixes:
NEWS.md:1andNEWS.md:59were both "(development version)" headings with no version, so R could not parse them. One heading now, "1.3.0.9010 (development version)" (no version bump).Par(defined by SpaDES.core in the module environment), data.table columns andlist2env()objects are declared in newR/globals.R. It callsglobalVariables()unqualified becausetests/testthat/test-ledgerNotInInputObjectsKey.R:15andtest-prepSpreadFitDataCacheExtra.R:9takeas.character(d[[1]])of every top-level call, which errors onutils::globalVariables(...).is,setNames,var,getFromNamespace,modifyListcome frommethods,stats,utils, now inreqdPkgs(fireSense_dataPrepFit.R:22), asfireSense_spreadPredictdoes.raster::unstackbyutils::unstack,Require::paddedFloatToCharby SpaDES.core) comes fromSpaDES.coreR/convertToPackage.RwriteImportSpadesCore()(about line 346), which writes@import <pkg>for everyreqdPkgsentry. It needs a fix there, not in the module. Addingmethods,statsandutilstoreqdPkgsadds one more such import (utils::unstack).Check (convertToPackage + rcmdcheck --no-manual, library /home/emcintir/.local/share/R/FireSenseTesting/packages/x86_64-pc-linux-gnu/4.6, nothing installed into it): base 0 errors, 1 warning, 2 notes; branch 0 errors, 1 warning, 0 notes.
Tests (convertToPackage + test_local): base 108 tests, 0 failed, 0 errors, 1 skipped; branch the same.
🤖 Generated with Claude Code