Skip to content

R CMD check: clear the two notes - #77

Merged
eliotmcintire merged 1 commit into
developmentfrom
checkhygiene
Oct 17, 2026
Merged

eliotmcintire merged 1 commit into
developmentfrom
checkhygiene

Conversation

@eliotmcintire

Copy link
Copy Markdown
Collaborator

The module's automated package check reported one warning and two notes, all present before. This clears the two notes; the warning needs a change in another package and remains.

Affects: nothing in results; check output only.

Technical details

Causes and fixes:

  • NEWS note: NEWS.md:1 and NEWS.md:59 were both "(development version)" headings with no version, so R could not parse them. One heading now, "1.3.0.9010 (development version)" (no version bump).
  • Undefined-names note: Par (defined by SpaDES.core in the module environment), data.table columns and list2env() objects are declared in new R/globals.R. It calls globalVariables() unqualified because tests/testthat/test-ledgerNotInInputObjectsKey.R:15 and test-prepSpreadFitDataCacheExtra.R:9 take as.character(d[[1]]) of every top-level call, which errors on utils::globalVariables(...). is, setNames, var, getFromNamespace, modifyList come from methods, stats, utils, now in reqdPkgs (fireSense_dataPrepFit.R:22), as fireSense_spreadPredict does.
  • Warning (not fixed): "replacing previous import" (14 lines, e.g. raster::unstack by utils::unstack, Require::paddedFloatToChar by SpaDES.core) comes from SpaDES.core R/convertToPackage.R writeImportSpadesCore() (about line 346), which writes @import <pkg> for every reqdPkgs entry. It needs a fix there, not in the module. Adding methods, stats and utils to reqdPkgs adds one more such import (utils::unstack).

Check (convertToPackage + rcmdcheck --no-manual, library /home/emcintir/.local/share/R/FireSenseTesting/packages/x86_64-pc-linux-gnu/4.6, nothing installed into it): base 0 errors, 1 warning, 2 notes; branch 0 errors, 1 warning, 0 notes.
Tests (convertToPackage + test_local): base 108 tests, 0 failed, 0 errors, 1 skipped; branch the same.

🤖 Generated with Claude Code

… reqdPkgs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@eliotmcintire eliotmcintire added the bug Something isn't working label Oct 17, 2026
@eliotmcintire
eliotmcintire merged commit 67a3e3d into development Oct 17, 2026
9 checks passed
@eliotmcintire
eliotmcintire deleted the checkhygiene branch October 17, 2026 20:47
eliotmcintire added a commit that referenced this pull request Oct 17, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019T7wFP7tXPDaRn42BFLzjr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant