Repository navigation
fitFileSuffix: read only the ledger files with this run's suffix - #78
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
eliotmcintire
added
enhancement
eliotmcintire
added a commit
that referenced
this pull request
Oct 18, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data-preparation step can now look up the fits of a test run, or only the production fits, according to one shared setting.
Affects: With
fitFileSuffixunset nothing changes; with it, the earlier spread fit is read only from files with that suffix.Depends-on: PredictiveEcology/fireSenseUtils#164
Technical details
Defect:
readSpreadFitLedger()calledlatestSpreadFits()without a suffix (R/readSpreadFitLedger.R:16), so it could not follow a test run's ledger. New parameterfitFileSuffix(default""), the same in fireSense_spreadFit, fireSense_ignitionFit, fireSense_dataPrepFit and fireSense_ELFs and read withSpaDES.core::paramCheckOtherMods(), so the modules must agree (set it once with.globals = list(fitFileSuffix = "_boundfix_rep81")). Tests: the suffix reacheslatestSpreadFits(). Suite: 344 passed, 0 failed (1 skipped) on this branch, 342 passed, 0 failed (1 skipped) on development; the new test fails on development. Floor raised to fireSenseUtils (>= 0.2.3.9104). No version bump.🤖 Generated with Claude Code
https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6