Repository navigation
Comments: ignition and escape models are Poisson, not Tweedie - #29
Closed
eliotmcintire wants to merge 1 commit into
Closed
eliotmcintire wants to merge 1 commit into
eliotmcintire wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
eliotmcintire
added
the
backwards compatible
Collaborator
Author
|
Not needed: the comments it fixes moved out with the draws in #33, and the replacement code in PredictiveEcology/fireSense_burn#31 already says Poisson. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two code comments said the fitted models were Tweedie. They will be Poisson once the ignitionFit change is merged, so the comments now say that.
Affects: nothing; comments only.
Technical details
fireSense_ignitionPredict.R:167(therpoiscall, formerly "can't use rtweedie") and:175("the escape model is tweedie") are reworded forcount:poisson; no code changes. NEWS bullet added. Full suite viaconvertToPackage()+test_local(): 41 tests, 152 pass, 0 fail, 2 skipped.🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv